Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ForceHttpsRedirectUris option applied to the RedirectUri and PostLogoutRedirectUri. Minor comment fixes. #202

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Jun 12, 2020

Added ForceHttpsRedirectUris config option. When set to true, forces the ProtocolMessage.RedirectUri and ProtocolMessage.PostLogoutRedirectUri in OnRedirectToIdentityProvider and OnRedirectToIdentityProviderForSignOut event handlers, respectively, to use the HTTPS scheme.

Plus minor comment fixes.

Related issues: #175, #115.

@pmaytak pmaytak requested review from jmprieur and jennyf19 June 12, 2020 08:07
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I left 2 suggestions.

pmaytak and others added 2 commits June 12, 2020 09:18
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @pmaytak

@pmaytak pmaytak merged commit 0b628e2 into master Jun 12, 2020
@pmaytak pmaytak deleted the pmaytak/ForceHttpsRedirectUris branch June 12, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants