app services roles #2166
Merged
app services roles #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the issuer is v2.0, and it does not go through Wilson's claimsTypeMapping, so the claims type will always be "roles"
the issuer is v2.0, and it does not go through Wilson's claimsTypeMapping, so the claims type will always be "roles"
…reAD/microsoft-identity-web into jmprieur/fixAppServicesRoles
…reAD/microsoft-identity-web into jmprieur/fixAppServicesRoles
…reAD/microsoft-identity-web into jmprieur/fixAppServicesRoles
jennyf19
reviewed
Apr 2, 2023
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationInformation.cs
Outdated
Show resolved
Hide resolved
jennyf19
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the roles claims type in apps services
the issuer is v2.0, and it does not go through
Wilson's claimsTypeMapping, so the claims type
will always be "roles"
See also; #2027