Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jennyf/ciam fix #2194

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Jennyf/ciam fix #2194

merged 1 commit into from
Apr 12, 2023

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Apr 12, 2023 •
edited
Loading

@jennyf19 jennyf19 requested a review from jmprieur April 12, 2023 01:16
jmprieur
jmprieur reviewed Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we need to remove the reference to the preview of MSAL.NET
  • Currently MergeExtraQueryParameters changes the merged options (which we might not want). I proposed a different implementation ... up to you

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs Outdated Show resolved Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs Outdated Show resolved Hide resolved
tests/DevApps/WebAppCallsMicrosoftGraph/WebAppCallsMicrosoftGraph.csproj Outdated Show resolved Hide resolved
jmprieur
jmprieur approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

Awesome!

@jennyf19 jennyf19 merged commit a2638c8 into master Apr 12, 2023
@jennyf19 jennyf19 deleted the jennyf/ciamFix branch April 12, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur