Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex bug #2207

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix regex bug #2207

merged 1 commit into from
Apr 19, 2023

Conversation

westin-m
Copy link
Contributor

Address a bug caused by extra space in regex.

@westin-m westin-m requested review from jmprieur and jennyf19 April 19, 2023 17:00
@westin-m westin-m linked an issue Apr 19, 2023 that may be closed by this pull request
Input string was not in a correct format exception in method IsChromiumVersionAtLeast #1811
Closed
jennyf19
jennyf19 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westin-m westin-m merged commit 8edd5df into master Apr 19, 2023
@jennyf19 jennyf19 deleted the westinm/regex-bug branch May 14, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input string was not in a correct format exception in method IsChromiumVersionAtLeast
2 participants
@westin-m @jennyf19