Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2460, #2410, #2394 #2499

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fixes #2460, #2410, #2394 #2499

merged 2 commits into from
Oct 3, 2023

Conversation

jmprieur
Copy link
Collaborator

@jmprieur jmprieur commented Oct 3, 2023 •
edited
Loading

Fixes #2410, #2460, #2394

Based on customer feedback, change the condition by which a host is used rather than another (DefaultTokenAcquisitionHost vs TokenAcquisitionAspnetCoreHost)

MZOLN
MZOLN approved these changes Oct 3, 2023
View reviewed changes
Copy link

@MZOLN MZOLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JoshLozensky
JoshLozensky requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@JoshLozensky JoshLozensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the build is failing, is that expected?

@westin-m westin-m self-requested a review October 3, 2023 22:39
jennyf19
jennyf19 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! let's go! :shipit:

JoshLozensky
JoshLozensky approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@JoshLozensky JoshLozensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build works now

@jmprieur jmprieur merged commit 5f191c2 into master Oct 3, 2023
@jmprieur jmprieur changed the title Fixes #2410, #2410 Fixes #2460, #2410 Oct 3, 2023
@jmprieur jmprieur changed the title Fixes #2460, #2410 Fixes #2460, #2410, #2394 Oct 4, 2023
@jmprieur jmprieur deleted the jmprieur/Fix2410 branch October 12, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@kllysng kllysng kllysng approved these changes

@JoshLozensky JoshLozensky JoshLozensky approved these changes

@MZOLN MZOLN MZOLN approved these changes

@westin-m westin-m Awaiting requested review from westin-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@jmprieur @jennyf19 @kllysng @JoshLozensky @MZOLN @westin-m