Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create design_proposal.md #2523

Merged
merged 1 commit into from
Oct 16, 2023
Merged

create design_proposal.md #2523

merged 1 commit into from
Oct 16, 2023

Conversation

kellyyangsong
Copy link
Contributor

No description provided.

jennyf19
jennyf19 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kewl! 🐩

@kellyyangsong kellyyangsong merged commit ceff540 into master Oct 16, 2023
4 checks passed
@kellyyangsong kellyyangsong deleted the kellysong/design-prop-template branch October 16, 2023 21:55
JoshLozensky
JoshLozensky requested changes Oct 16, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/design_proposal.md

1-2 sentences. Say what this is about.

## Motivation and goals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we change goals to "success criteria" I've found this phrasing generally results in more specific and measurable goals/criteria

.github/ISSUE_TEMPLATE/design_proposal.md

## In scope

A list of major scenarios, perhaps in priority order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are "major scenarios"? Can we define this and/or provide an example?

.github/ISSUE_TEMPLATE/design_proposal.md

## Out of scope

Scenarios you explicitly want to exclude.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.... is feature an appropriate descriptor here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comments Josh!! Will fix in later iteration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLozensky JoshLozensky JoshLozensky requested changes

@westin-m westin-m westin-m approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kellyyangsong @jennyf19 @JoshLozensky @westin-m