Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultTokenAcquirerFactoryImplementation use ConcurrentDictionary #2764

Merged
merged 1 commit into from
Apr 16, 2024
Merged

DefaultTokenAcquirerFactoryImplementation use ConcurrentDictionary #2764

merged 1 commit into from
Apr 16, 2024

Conversation

sammurrayms
Copy link
Contributor

@sammurrayms sammurrayms commented Apr 16, 2024 •
edited
Loading

DefaultTokenAcquirerFactoryImplementation use ConcurrentDictionary

DefaultTokenAcquirerFactoryImplementation now supports multiple regions and more thread safe.

Description

  • The DefaultTokenAcquirerFactoryImplementation now incorporates the region within the key string, resolving a bug wherein getting a token acquirer for a particular region could inadvertently yield a token acquirer meant for a different region.
  • Additionally, the implementation now employs a ConcurrentDictionary to manage its data, enhancing thread safety in scenarios where multiple threads may attempt to create a TokenAcquirer simultaneously.

@sammurrayms sammurrayms marked this pull request as ready for review April 16, 2024 12:07
jennyf19
jennyf19 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 merged commit 3083a3c into AzureAD:rel/v2 Apr 16, 2024
6 checks passed
@sammurrayms
Copy link
Contributor Author

#2765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammurrayms @jennyf19