changes to the cachekey to use tokenNotificationArgs #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmaytak you could probably review this now, i don't expect much to change. If you want to build it and test it, although it's probably easier to wait until MSAL .NET releases. |
pmaytak
reviewed
Jul 3, 2020
src/Microsoft.Identity.Web/TokenCacheProviders/IMsalTokenCacheProvider.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web/TokenCacheProviders/MsalAbstractTokenCacheProvider.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web/TokenCacheProviders/MsalAbstractTokenCacheProvider.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web/TokenCacheProviders/Distributed/MsalDistributedTokenCacheAdapter.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jul 7, 2020
#294) * This is an improvement leveraging the fact that MSAL.NET now exposes TokenCacheNotificationArgs.HasTokens which enable applications (and Microsoft.Identity.Web) to remove cache entries when the cache is empty Also OnBeforeAccessAsync tests if the SuggestedCacheKey is null (can happen in B2C cases, as we still call GetAccountsAsync() * Removing the un-necessary condition on suggested cache key (which should not be null in a Write to cache) It can be null in a read to cache if for instance, calling GetAccountsAsync() * Removing an extra line * remove secret Co-authored-by: jennyf19 <jeferrie@microsoft.com>
pmaytak
approved these changes
Jul 7, 2020
src/Microsoft.Identity.Web/TokenCacheProviders/Distributed/MsalDistributedTokenCacheAdapter.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release of MSAL .NET will surface the cache key to use in the tokenNotificationArgs, so we'll use that instead.
Making this draft PR for ease of testing. cc: @jmprieur
#235