Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align editor config with other libraries #3079

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

westin-m
Copy link
Contributor

Closes #3050

Edit .editorconfig to align with SAL, Wilson, MISE.

@westin-m westin-m requested a review from a team as a code owner October 10, 2024 21:34
@jmprieur
Copy link
Collaborator

what are the consequences on the current code?

@westin-m
Copy link
Contributor Author

what are the consequences on the current code?

No new warnings come as a result of these changes. These rules are already being followed and commonly enforced in reviews. Nevertheless, the benefit is that the enforcement will now be consistent across our libraries.

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @westin-m

@jennyf19 jennyf19 merged commit 78719ac into master Oct 11, 2024
5 checks passed
@jennyf19 jennyf19 deleted the westin/editorConfig branch October 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align editor config with other libraries
5 participants