Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflection in MemoryCache tests to support both versions seen in .NET 9 RCs #3085

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix reflection in MemoryCache tests to support both versions seen in .NET 9 RCs #3085

merged 1 commit into from
Oct 14, 2024

Conversation

msbw2
Copy link
Contributor

@msbw2 msbw2 commented Oct 14, 2024

Fix reflection in MemoryCache tests to support both versions seen in .NET 9 RCs. In RC1 there was one entry collection while in RC2 it was split back out as seen in previous versions of .NET: dotnet/runtime@7ca789e

@msbw2 msbw2 requested a review from a team as a code owner October 14, 2024 07:38
jmprieur
jmprieur approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msbw2
There is a lot of chrun in the in memory cache

jmprieur
jmprieur approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msbw2
There is a lot of chrun in the. Net in memory cache!

jennyf19
jennyf19 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@msbw2 msbw2 merged commit bf77c78 into master Oct 14, 2024
5 checks passed
@msbw2 msbw2 deleted the brettwhite/memorycache-reflection branch October 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbw2 @jmprieur @jennyf19