Split aot compatible and incompatible methods #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SaurabhMSFT. Is there duplication of code? I couldn't figure out without pulling the branch (which I have not done yet) |
|
I had to copy the method DeserializeOutputImplAsync and split the if block on left side(line 398-405) into two methods. Due to that if clause DeserializeOutputImplAsync method wasn't AOT compatible. |
jennyf19
approved these changes
Oct 20, 2024
jmprieur
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Deserialize method would call an aot incompatible if the output info is null. We split the method into two such that the aot compatible code calls overload with JsonTypeInfo