Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional HttpResponse parameter to ReplyForbiddenWithWwwAuthenticateHeaderAsync. Handle null context. #412

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add optional HttpResponse parameter to ReplyForbiddenWithWwwAuthenticateHeaderAsync. Handle null context. #412

merged 2 commits into from
Aug 6, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Aug 6, 2020

Issue #380

@pmaytak pmaytak requested review from jmprieur and jennyf19 August 6, 2020 07:10
jmprieur
jmprieur reviewed Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • We need to fix the typo
  • we might want to throw some exception if both the HttpContext and the HttpResponse are null? maybe an ArgumentException (telling the app to pass-in the HttpResponse in that case as the HttpContext is not accessible?)

src/Microsoft.Identity.Web/ITokenAcquisition.cs Outdated Show resolved Hide resolved
src/Microsoft.Identity.Web/TokenAcquisition.cs Show resolved Hide resolved
src/Microsoft.Identity.Web/TokenAcquisition.cs Outdated Show resolved Hide resolved
jmprieur
jmprieur approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @pmaytak

@pmaytak pmaytak merged commit bd0c266 into master Aug 6, 2020
@pmaytak pmaytak deleted the pmaytak/nullHttpContext branch August 6, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmaytak @jmprieur @jennyf19