Make GetTokenForAppAsync less confusing and allow to pass tenantId #413 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked with @hpsin and here is what we agreed to: - Change the signature of `GetAccessTokenForUserAsync` to take a `string` (instead of a `IEnumerable<string>`) as there is only one possible string for a given resource of App Id URI AppIdUri: "AppIdUri/.default". Check that the resource ends in "./default" - Add an additional optional parameter `tenant` to support this scenario, and verify that this tenant is not organizations (and of course common and consumers, which don't make sense) ```CSharp public async Task<string> GetAccessTokenForAppAsync(string scope, string? tenant = null) ```
jmprieur
requested review from
jennyf19 and
pmaytak
and removed request for
jennyf19
jennyf19
reviewed
Aug 9, 2020
jennyf19
reviewed
Aug 9, 2020
jennyf19
reviewed
Aug 9, 2020
jennyf19
reviewed
Aug 9, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
tests/Microsoft.Identity.Web.Test.Integration/AcquireTokenForAppIntegrationTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
- Adding an aka.ms link to the error messages (https://aka.ms/ms-id-web/daemon-scenarios) - using constants for the meta-tenants - Testing all the meta tenant Thanks @jennyf19 for this PR feedback
…https://github.com/AzureAD/microsoft-identity-web into jmprieur/GetTokenForAppAsyncBreakingChangesAndFix413
|
Consumers is allowed, since it is a single tenant. |
hpsin
suggested changes
Aug 10, 2020
jennyf19
added a commit
that referenced
this pull request
Aug 12, 2020
* Initial commit (does not build) * Updating Web API. Todo: - see if we could have some commonalities between the Web app and Web API builder (configuration?) - Enfoce configuration for CallsWebAPI can only be called if configuration for the AddMicrosoftWebApp/Api * Improving the API * Improving the API. * Updating unit tests so that they build Fixing a few. * Renamings an clean-up discussed with DevDiv - Renaming AddMicrosoftWebApp to AddMicrosoftIdentityPlatformWebApp, - Renaming AddMicrosoftWebApi to AddMicrosoftIdentityPlatformWebApi, - MicrososoftAppCallingWebApiAuthenticationBuilder.AddInXXXTokenCaches etc ... return their parent builder. * More renaming * Test fix. * Renaming of more overrides * Updating the templates * initial commit api w/microsoftIdentity * merge conflicts + update templates * Making the templates work with 0.3.*-* * few more updates * Make GetTokenForAppAsync less confusing and allow to pass tenantId #413 (#424) * Make GetTokenForAppAsync less confusing and allow to pass tenantId #413 Checked with @hpsin and here is what we agreed to: - Change the signature of `GetAccessTokenForUserAsync` to take a `string` (instead of a `IEnumerable<string>`) as there is only one possible string for a given resource of App Id URI AppIdUri: "AppIdUri/.default". Check that the resource ends in "./default" - Add an additional optional parameter `tenant` to support this scenario, and verify that this tenant is not organizations (and of course common and consumers, which don't make sense) ```CSharp public async Task<string> GetAccessTokenForAppAsync(string scope, string? tenant = null) ``` * Update src/Microsoft.Identity.Web/ITokenAcquisition.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * Addressing PR feedback: - Adding an aka.ms link to the error messages (https://aka.ms/ms-id-web/daemon-scenarios) - using constants for the meta-tenants - Testing all the meta tenant Thanks @jennyf19 for this PR feedback * Addressing @hpsin 's PR feedback. * fix tests * add xml comments * few spelling changes * renaming of CallsWebApi to EnableTokenAcquisitionToCallDownstreamApi * - Adding a missing renaming for AddMicrosoftWebApp => AddMicrosoftIdentityWebApp - Updating the ITokenAcquisition.GetTokenForAppAsync signature to match the class. * Fixing the TodoListService controller in WebAppCallsWebApiCallsGraph * pr feedback * reverting pr feedback Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com>
jmprieur
deleted the
jmprieur/GetTokenForAppAsyncBreakingChangesAndFix413
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked with @hpsin and here is what we agreed to:
GetAccessTokenForUserAsyncto take astring(instead of aIEnumerable<string>) as there is only one possible string for a given resource of App Id URI AppIdUri: "AppIdUri/.default". Check that the resource ends in "./default"tenantto support this scenario, and verify that this tenant is not organizations (and of course common and consumers, which don't make sense)