Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an options delegate for methods that add caches. #450

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Add an options delegate for methods that add caches. #450

merged 2 commits into from
Aug 14, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Aug 14, 2020

Issue #426

@pmaytak pmaytak requested review from jmprieur and jennyf19 August 14, 2020 01:35
jennyf19
jennyf19 approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this updated w/master, you should be getting the warnings anymore.
:shipit:

@pmaytak pmaytak force-pushed the pmaytak/optionsDelegate branch from b084a38 to 920cf2b Compare August 14, 2020 01:51
@pmaytak
Copy link
Contributor Author

pmaytak commented Aug 14, 2020

is this updated w/master, you should be getting the warnings anymore.
:shipit:

It is. Thanks.

@pmaytak pmaytak merged commit a854811 into master Aug 14, 2020
@pmaytak pmaytak deleted the pmaytak/optionsDelegate branch August 14, 2020 02:00
@pmaytak pmaytak linked an issue Aug 14, 2020 that may be closed by this pull request
AddInMemoryTokenCaches should take options and delegates #426
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddInMemoryTokenCaches should take options and delegates
2 participants
@pmaytak @jennyf19