Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add memory cache options #640

Merged
merged 2 commits into from
Oct 3, 2020
Merged

add memory cache options #640

merged 2 commits into from
Oct 3, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Oct 2, 2020 •
edited
Loading

jmprieur
jmprieur approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jennyf19
do we need a unit test? (we cannot know the size of the in memory cache, so that might be a bit pointless?)

pmaytak
pmaytak approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jennyf19
Copy link
Collaborator Author

jennyf19 commented Oct 3, 2020

i added a small one. thx.

In reply to: 501235649 [](ancestors = 501235649)

@jennyf19 jennyf19 merged commit f609eee into master Oct 3, 2020
@jennyf19 jennyf19 deleted the jennyf/memoryCache branch October 3, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@pmaytak pmaytak pmaytak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennyf19 @jmprieur @pmaytak