renaming #701
Merged
renaming #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
commented
Oct 20, 2020
| ClientId = AppServiceAuthenticationInformation.ClientId, | ||
| ClientSecret = AppServiceAuthenticationInformation.ClientSecret, | ||
| Instance = AppServiceAuthenticationInformation.Issuer, | ||
| ClientId = AppServicesAuthenticationInformation.ClientId, |
There was a problem hiding this comment.
we should consider some refactoring in tokenAcqusition so we don't have to repeat this code. not something for this PR, but something for the future we shoudl consider.
jmprieur
approved these changes
Oct 20, 2020
| @@ -53,10 +53,10 @@ protected override Task<AuthenticateResult> HandleAuthenticateAsync() | |||
| ClaimsPrincipal claimsPrincipal = new ClaimsPrincipal(new ClaimsIdentity( | |||
| jsonWebToken.Claims, | |||
| idp, | |||
| "name", // v1.0 | |||
| Constants.NameClaim, // v1.0 | |||
There was a problem hiding this comment.
That makes me think that we need to check the "ver" claim, and use the right constant (NameClaim or prefered_username, depending on the version.
jmprieur
added a commit
that referenced
this pull request
Oct 20, 2020
* First step of the integration of Easy-auth with Microsoft.Identity.Web * Sign-in and Sign-out now work correctly * Reverting changes to TokenAcquisition * Updating the EasyAuth code and adding debugging capabilities * Improving the developer experience. * Now works when deployed with EasyAuth "on" * Cleaning-up * Removing the test project * Fixing * Update src/Microsoft.Identity.Web/EasyAuth/AppServiceAuthenticationBuilderExtensions.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * Update src/Microsoft.Identity.Web/EasyAuth/AppServiceAuthenticationBuilderExtensions.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * Update src/Microsoft.Identity.Web/EasyAuth/AppServiceAuthenticationInformation.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * Update src/Microsoft.Identity.Web/EasyAuth/AppServiceAuthenticationDefaults.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * renaming (#701) * renaming * a few more edits and name changes * fix error + warnings * Adding the test app. * Improvements: - in the authentication handler, processes both v1.0 and v2.0 IdTokens - Fixing CA warnings - Adding a page (Debugging) which explains how to debug the EasyAuth integration locally. * Addressing PR feedback Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.