Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tfp double up in legacy b2c domains #796

Merged
merged 3 commits into from
Dec 1, 2020
Merged

fix tfp double up in legacy b2c domains #796

merged 3 commits into from
Dec 1, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Dec 1, 2020

No description provided.

@jennyf19 jennyf19 requested a review from jmprieur December 1, 2020 17:15
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

tested on the offending app (B2C web app calling web API, where the Instance was set to http://login.microsoftonline.com/tfp/ and this worked.

@@ -505,6 +505,16 @@ private async Task<IConfidentialClientApplication> BuildConfidentialClientApplic
}
}

private void PrepareAuthorityInstanceForMsal()
{
if (_microsoftIdentityOptions.IsB2C && _applicationOptions.Instance.EndsWith("/tfp/"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be checked in the case of the instance ending with /tfp also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. @jmprieur and i discussed this and we are just focusing on a fix for the template, which has /. developers should not organically use this, it's not even in any documentation. this is a quick fix for an issue we have, and a longer term fix is more involved w/msal .net fixes and asp .net templates. if customer have issues, we can look at this, or move forward faster w/the fixes needed in the other libs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jennyf19 jennyf19 merged commit a4bde02 into master Dec 1, 2020
@jennyf19 jennyf19 deleted the jennyf/tfp branch December 9, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants