Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cookie issue #817

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix cookie issue #817

merged 1 commit into from
Dec 7, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Dec 6, 2020

#809 & #133 need to do more testing, so WIP

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jennyf19 jennyf19 marked this pull request as ready for review December 6, 2020 20:27
jmprieur
jmprieur approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested on the dotnet new --auth Individual scenario.

@jennyf19 jennyf19 merged commit 19de056 into master Dec 7, 2020
@jennyf19 jennyf19 deleted the jennyf/cookies branch December 7, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur