Add graph & api call to worker2 #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
changed the title
jennyf19
changed the title
bgavrilMS
reviewed
Jan 22, 2021
bgavrilMS
reviewed
Jan 22, 2021
bgavrilMS
reviewed
Jan 22, 2021
bgavrilMS
approved these changes
Jan 22, 2021
pmaytak
approved these changes
Jan 22, 2021
jmprieur
requested changes
Jan 24, 2021
There was a problem hiding this comment.
This is an awesome start @jennyf19 !
I realize the amount of work you must have put to get to this outcome, considering how complex the templates are, and how hard and iterative it is to test them
There is little typo in the processor directive in GreeterService.cs
This means the template for this file is not correctly expanded when running the following command:
dotnet new worker2 --auth SingleOrg --called-api-url "https://graph.microsoft.com/beta/me" --called-api-scopes "user.read"
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#900
Still need to test and build the template from the branch.