Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

By default redirect URL should be https. #164

Closed
brentschmaltz opened this issue Aug 10, 2016 · 2 comments
Closed

By default redirect URL should be https. #164

brentschmaltz opened this issue Aug 10, 2016 · 2 comments
Assignees
@lovemaths
Labels
breaking change done P1
Milestone
3.0.6

Comments

@brentschmaltz
Copy link
Member

https://github.com/AzureAD/passport-azure-ad/pull/162/files#diff-dac9acad3c0a1da97f74286ae8c79470L154

Allows http by default. We should fault on http and require a switch on options to be set.
@brentschmaltz brentschmaltz mentioned this issue Aug 10, 2016
Closed
@jeffwilcox
Copy link
Contributor

Thanks. Happy to validate this one once a fix is available; we have deployed dev-test-prod that are all sitting behind SSL terminated app service instances, but for local dev we have a debug flag to allow debugging using HTTP + port 3000.

@polita polita added the P1 label Sep 1, 2016
@polita polita added this to the 3.0.0 milestone Sep 1, 2016
@polita
Copy link
Contributor

polita commented Sep 1, 2016

Need an option to specify allowing http redirectUri

lovemaths added a commit that referenced this issue Sep 29, 2016
@lovemaths
Issue #164: By default redirectUrl is https
33a971a
@lovemaths lovemaths added the done label Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lovemaths lovemaths

Labels
breaking change done P1
Projects
None yet
Milestone
3.0.6
Development

No branches or pull requests
4 participants
@jeffwilcox @brentschmaltz @lovemaths @polita