Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Missing email claim for B2C #218

Closed
ghost opened this issue Sep 24, 2016 · 3 comments
Closed

Missing email claim for B2C #218

ghost opened this issue Sep 24, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Sep 24, 2016

There is no way to mention the name of a custom sign-in policy name in the '/examples/login-oidc-b2c/client_config_b2c.js' file, unlike the examples/server-oauth2-b2c/server_config.js file (policyName). I am unable to get proper claims post sign-in (especially email) for my Node app with the current configuration scope.

@lovemaths
Copy link
Contributor

Passport has a bug returning the email claim. We are working on the fix and we will release as soon as we can with a fix to B2C. Thanks.

@lovemaths lovemaths changed the title Unable to mention policy name in config file for OIDC B2C login Missing email claim for B2C Sep 26, 2016
@lovemaths
Copy link
Contributor

@TejaK1 By the way, OIDC figures out the policy by itself, we don't provide policy names in the config file. User just needs to make sure they add the policy name in the route they want to authenticate, please have a look at the routes in 'views/index.ejs'. I changed the title of this issue to 'missing email claim for B2C'.

@lovemaths lovemaths self-assigned this Sep 26, 2016
@lovemaths lovemaths added this to the 3.0.0 milestone Sep 26, 2016
@ghost
Copy link
Author

ghost commented Sep 26, 2016

Yes, I have the policy name updated in the routes. I didn't know if the 'no email' found' error was thrown due to not mentioning the policy name in the configuration file also. Thanks for the clarification.

lovemaths added a commit that referenced this issue Sep 27, 2016
(1) Rewrote the metadata loading and the configuration code. Restructured OIDCStrategy.
(2) #188 B2C mocha tests (partially done, waiting for the AAD fix of missing nonce to add test for hybrid/code flow)
(3) #165 rename 'callbackURL' and 'returnURL' to 'redirectUrl'.
(4) #189 Extensibility to allow issuer validation when going against commend end point
(5) #194 error message for 'sub' mismatch is incorrect after redeeming 'code'
(6) #218 missing email claim for B2C
@lovemaths lovemaths added the done label Sep 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant