Pull Arc-Proxy from MAR #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeDaboub
requested review from
bavneetsingh16,
deeksha345 and
anagg929
as code owners
JorgeDaboub
force-pushed
the
jorgedaboub/proxy_pull_mcr
branch
from
a5b894e to
628c1ea
Compare
bavneetsingh16
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
This PR deprecates the use of a storage account for downloading the Arc proxy in the az connectedk8s proxy command. The binary is now pulled from the Microsoft Artifact Registry (MAR). Additionally, the license and third-party notice files are downloaded alongside the binary.
This PR is dependent on another PR (currently blocked by CCOA) to add support for additional architectures to the proxy. It will be updated and merged once that work is complete.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Testing
In a previous PR, we added additional checks to the existing proxy command integration tests to ensure proper functionality, and all tests are passing. However, due to the changes involving downloads for different operating systems (the pipeline only runs on one OS), I manually tested the removal of old proxy versions and the download of new ones on all supported OSs.
Manually tested on:
Windows
Ubuntu
Mac/Darwin
