Skip to content

Fix spinning entities #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AzureDoom merged 1 commit into from
May 13, 2025
Merged

Fix spinning entities #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions common/src/main/java/mod/azure/azurelib/ai/pathing/AzureNavigation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,22 +112,30 @@ public boolean moveTo(Entity entity, double d) {
return true;
}

@Override
public void tick() {
super.tick();
// If the entity is below 0.8 units in width, the pathing tends to "fail," causing issues like
// MC-226637 to take place. By forcing the width check to calculate at least a MINIMUM value of 1.0,
// we effectively remove this bug for smaller entities, while keeping larger entity navigation behaviors
// untouched. Might be a performance improvement, as the hitbox and AI won't update to "spin." -Modrome
public float getMinimumWidth() {
return Math.max(this.mob.getBbWidth(),1.0F); //Return whichever value is greater, for small entities, this returns 1.0 no matter what, fixing our spinning entities.
}

@Override
public void tick() {
super.tick();
if (this.isDone()) {
if (this.pathToPosition != null) {
if (this.pathToPosition.closerToCenterThan(this.mob.position(), this.mob.getBbWidth()) || this.mob.getY() > (double)this.pathToPosition.getY() && BlockPos.containing(this.pathToPosition.getX(), this.mob.getY(), this.pathToPosition.getZ()).closerToCenterThan(this.mob.position(), this.mob.getBbWidth())) {
if (this.pathToPosition.closerToCenterThan(this.mob.position(), getMinimumWidth()) || this.mob.getY() > (double)this.pathToPosition.getY() && BlockPos.containing(this.pathToPosition.getX(), this.mob.getY(), this.pathToPosition.getZ()).closerToCenterThan(this.mob.position(), getMinimumWidth())) {
this.pathToPosition = null;
} else {
this.mob.getMoveControl().setWantedPosition(this.pathToPosition.getX(), this.pathToPosition.getY(), this.pathToPosition.getZ(), this.speedModifier);
}
}
return;
}
if (this.getTargetPos() != null)
this.mob.getLookControl().setLookAt(this.getTargetPos().getX(), this.getTargetPos().getY(), this.getTargetPos().getZ());
}
if (this.getTargetPos() != null)
this.mob.getLookControl().setLookAt(this.getTargetPos().getX(), this.getTargetPos().getY(), this.getTargetPos().getZ());
}

private boolean isAt(Path path, float threshold) {
final Vec3 pathPos = path.getNextEntityPos(this.mob);
Expand Down