[Tables] Don't deserialize DateTime to avoid losing precision (Azure#…

…12650) Fixes Azure#12646 Tables service supports ns precision DateTime however JavaScript doesn't. As part of entity deserialization, whenever we get a property with type Edm.DateTime we parse it into a JavaScript Date object, which can lead to losing precision. To fix this we need to disable the default deserialization for Edm.DateTime and give the user an "edm" object, similar to what we do for Guid and Int64 ```typescript { partitionKey: "p1", rowKey: "r1", blahblah: {type: "DateTime", value:"the date"} } ```
AzureSDKAutomation · Nov 20, 2020 · 1810528 · 1810528
1 parent 54f8879
commit 1810528
Show file tree

Hide file tree

Showing 10 changed files with 74 additions and 77 deletions.
diff --git a/sdk/tables/data-tables/CHANGELOG.md b/sdk/tables/data-tables/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 1.0.0-beta.4 (Unreleased)
 
+### Breaking Changes
+
+- Don't deserialize DateTime into a JavaScript Date to avoid losing precision [#12650](https://github.com/Azure/azure-sdk-for-js/pull/12650)
 
 ## 1.0.0-beta.3 (2020-11-12)
 

diff --git a/...ableclient_createentity_getentity_and_delete/recording_should_createentity_with_date.json b/...ableclient_createentity_getentity_and_delete/recording_should_createentity_with_date.json
diff --git a/...client_createentity_getentity_and_delete/recording_should_createentity_with_datetime.json b/...client_createentity_getentity_and_delete/recording_should_createentity_with_datetime.json
diff --git a/.../tableclient_createentity_getentity_and_delete/recording_should_createentity_with_date.js b/.../tableclient_createentity_getentity_and_delete/recording_should_createentity_with_date.js
diff --git a/...leclient_createentity_getentity_and_delete/recording_should_createentity_with_datetime.js b/...leclient_createentity_getentity_and_delete/recording_should_createentity_with_datetime.js
diff --git a/sdk/tables/data-tables/review/data-tables.api.md b/sdk/tables/data-tables/review/data-tables.api.md
@@ -96,7 +96,7 @@ export type DeleteTableResponse = TableDeleteHeaders & {
 // @public
 export interface Edm<T extends EdmTypes> {
     type: T;
-    value: T extends "Binary" ? Uint8Array : T extends "Boolean" ? boolean : T extends "DateTime" ? Date : T extends "Double" ? number : T extends "Int32" ? number : string;
+    value: T extends "Binary" ? Uint8Array : T extends "Boolean" ? boolean : T extends "Double" ? number : T extends "Int32" ? number : string;
 }
 
 // @public

diff --git a/sdk/tables/data-tables/src/models.ts b/sdk/tables/data-tables/src/models.ts
@@ -398,8 +398,6 @@ export interface Edm<T extends EdmTypes> {
     ? Uint8Array
     : T extends "Boolean"
     ? boolean
-    : T extends "DateTime"
-    ? Date
     : T extends "Double"
     ? number
     : T extends "Int32"

diff --git a/sdk/tables/data-tables/src/serialization.ts b/sdk/tables/data-tables/src/serialization.ts
@@ -113,7 +113,7 @@ function getTypedObject(value: any, type: string): any {
     case Edm.String:
       return value;
     case Edm.DateTime:
-      return new Date(value);
+      return { value, type: "DateTime" };
     case Edm.Int64:
       return { value, type: "Int64" };
     case Edm.Guid: