Skip to content

Commit

Permalink
update changelog date and samples (Azure#15601)
Browse files Browse the repository at this point in the history
  • Loading branch information
KarishmaGhiya authored Jun 8, 2021
1 parent 0dafe59 commit 3f9a868
Show file tree
Hide file tree
Showing 20 changed files with 42 additions and 18 deletions.
2 changes: 1 addition & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 1.0.0-beta.4 (Unreleased)
## 1.0.0-beta.4 (2021-06-07)

### New Features

Expand Down
2 changes: 2 additions & 0 deletions sdk/metricsadvisor/ai-metrics-advisor/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ module.exports = function(config) {
"METRICS_ADVISOR_AZURE_SQLSERVER_METRIC_ID_1",
"METRICS_ADVISOR_ALERT_CONFIG_ID",
"METRICS_ADVISOR_ALERT_ID",
"METRICS_EVENTHUB_CONNECTION_STRING",
"METRICS_EVENTHUB_CONSUMER_GROUP",
"AZURE_CLIENT_ID",
"AZURE_CLIENT_SECRET",
"AZURE_TENANT_ID"
Expand Down
7 changes: 7 additions & 0 deletions sdk/metricsadvisor/ai-metrics-advisor/sample.env
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
METRICS_ADVISOR_ENDPOINT=https://<resource name>.cognitiveservices.azure.com/
METRICS_ADVISOR_SUBSCRIPTION_KEY=<subscription key>
METRICS_ADVISOR_API_KEY=<api key>
# METRICS_ADVISOR_METRIC_ID=
# METRICS_ADVISOR_DETECTION_CONFIG_ID=
# METRICS_ADVISOR_HOOK_ID=
# METRICS_ADVISOR_DATAFEED_ID=
# METRICS_ADVISOR_INCIDENT_ID=
# METRICS_ADVISOR_SQL_SERVER_CONNECTION_STRING=
# METRICS_ADVISOR_AZURE_SQL_SERVER_QUERY=

# Our tests assume that TEST_MODE is "playback" by default. You can
# change it to "record" to generate new recordings, or "live" to bypass the recorder entirely.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ async function updateAlertConfig(
]
};
console.log(`Updating alerting configuration ${detectionConfigId}`);
const updated = await adminClient.updateAlertConfig(alertConfigId, patch);
await adminClient.updateAlertConfig(alertConfigId, patch);
const updated = await adminClient.getAlertConfig(alertConfigId);
return updated;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ async function updateDataFeed(client: MetricsAdvisorAdministrationClient, dataFe

try {
console.log(`Updating datafeed ${dataFeedId}...`);
const updated = await client.updateDataFeed(dataFeedId, patch);
await client.updateDataFeed(dataFeedId, patch);
const updated = await client.getDataFeed(dataFeedId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating data feed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ async function updateDatasourceCredential(

try {
console.log(`Updating credential ${credentialId}...`);
const updated = await client.updateDatasourceCredential(credentialId, patch);
await client.updateDatasourceCredential(credentialId, patch);
const updated = await client.getDataFeed(credentialId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating credential");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ async function updateDetectionConfig(
]
};
console.log(`Updating existing detection configuration '${configId}'`);
const result = await adminClient.updateDetectionConfig(configId, patch);
await adminClient.updateDetectionConfig(configId, patch);
const result = adminClient.getDetectionConfig(configId);
console.log(result);
return result;
}
Expand Down
3 changes: 2 additions & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/samples-dev/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ async function updateEmailHook(client: MetricsAdvisorAdministrationClient, hookI
toList: ["test2@example.com", "test3@example.com"]
}
};
const response = await client.updateHook(hookId, emailPatch);
await client.updateHook(hookId, emailPatch);
const response = await client.getHook(hookId);
console.log(response);
return response;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ async function updateAlertConfig(adminClient, alertConfigId, detectionConfigId,
]
};
console.log(`Updating alerting configuration ${detectionConfigId}`);
const updated = await adminClient.updateAlertConfig(alertConfigId, patch);
await adminClient.updateAlertConfig(alertConfigId, patch);
const updated = await adminClient.getAlertConfig(alertConfigId);
return updated;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ async function updateDataFeed(client, dataFeedId) {

try {
console.log(`Updating datafeed ${dataFeedId}...`);
const updated = await client.updateDataFeed(dataFeedId, patch);
await client.updateDataFeed(dataFeedId, patch);
const updated = await client.getDataFeed(dataFeedId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating data feed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ async function updateDatasourceCredential(client, credentialId) {

try {
console.log(`Updating credential ${credentialId}...`);
const updated = await client.updateDatasourceCredential(credentialId, patch);
await client.updateDatasourceCredential(credentialId, patch);
const updated = await client.getDataFeed(credentialId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating credential");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ async function updateDetectionConfig(adminClient, configId) {
]
};
console.log(`Updating existing detection configuration '${configId}'`);
const result = await adminClient.updateDetectionConfig(configId, patch);
await adminClient.updateDetectionConfig(configId, patch);
const result = adminClient.getDetectionConfig(configId);
console.log(result);
return result;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ async function updateEmailHook(client, hookId) {
toList: ["test2@example.com", "test3@example.com"]
}
};
const response = await client.updateHook(hookId, emailPatch);
await client.updateHook(hookId, emailPatch);
const response = await client.getHook(hookId);
console.log(response);
return response;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"version": "1.0.0",
"description": "Azure Metrics Advisor client library samples for JavaScript",
"engine": {
"engines": {
"node": ">=12.0.0"
},
"repository": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"version": "1.0.0",
"description": "Azure Metrics Advisor client library samples for TypeScript",
"engine": {
"engines": {
"node": ">=12.0.0"
},
"scripts": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ async function updateAlertConfig(
]
};
console.log(`Updating alerting configuration ${detectionConfigId}`);
const updated = await adminClient.updateAlertConfig(alertConfigId, patch);
await adminClient.updateAlertConfig(alertConfigId, patch);
const updated = await adminClient.getAlertConfig(alertConfigId);
return updated;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ async function updateDataFeed(client: MetricsAdvisorAdministrationClient, dataFe

try {
console.log(`Updating datafeed ${dataFeedId}...`);
const updated = await client.updateDataFeed(dataFeedId, patch);
await client.updateDataFeed(dataFeedId, patch);
const updated = await client.getDataFeed(dataFeedId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating data feed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ async function updateDatasourceCredential(

try {
console.log(`Updating credential ${credentialId}...`);
const updated = await client.updateDatasourceCredential(credentialId, patch);
await client.updateDatasourceCredential(credentialId, patch);
const updated = await client.getDataFeed(credentialId);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating credential");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ async function updateDetectionConfig(
]
};
console.log(`Updating existing detection configuration '${configId}'`);
const result = await adminClient.updateDetectionConfig(configId, patch);
await adminClient.updateDetectionConfig(configId, patch);
const result = adminClient.getDetectionConfig(configId);
console.log(result);
return result;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ async function updateEmailHook(client: MetricsAdvisorAdministrationClient, hookI
toList: ["test2@example.com", "test3@example.com"]
}
};
const response = await client.updateHook(hookId, emailPatch);
await client.updateHook(hookId, emailPatch);
const response = await client.getHook(hookId);
console.log(response);
return response;
}
Expand Down

0 comments on commit 3f9a868

Please sign in to comment.