Generated from a155255d1165f48169f8549ef614f628a1868397

Addressed comments

sdk/features/arm-features/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019 Microsoft
+Copyright (c) 2020 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/features/arm-features/README.md

@@ -19,8 +19,9 @@ npm install @azure/arm-features
 
 ##### Install @azure/ms-rest-nodeauth
 
+- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
 ```bash
-npm install @azure/ms-rest-nodeauth
+npm install @azure/ms-rest-nodeauth@"^3.0.0"
 ```
 
 ##### Sample code
@@ -95,4 +96,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
 
 - [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)
 
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Ffeatures%2Farm-features%2FREADME.png)
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/features/arm-features/README.png)

sdk/features/arm-features/package.json

@@ -4,9 +4,9 @@
   "description": "FeatureClient Library with typescript type definitions for node.js and browser.",
   "version": "1.0.3",
   "dependencies": {
-    "@azure/ms-rest-azure-js": "^1.3.2",
-    "@azure/ms-rest-js": "^1.8.1",
-    "tslib": "^1.9.3"
+    "@azure/ms-rest-azure-js": "^2.0.1",
+    "@azure/ms-rest-js": "^2.0.4",
+    "tslib": "^1.10.0"
   },
   "keywords": [
     "node",
@@ -20,11 +20,11 @@
   "module": "./esm/featureClient.js",
   "types": "./esm/featureClient.d.ts",
   "devDependencies": {
-    "typescript": "^3.1.1",
-    "rollup": "^0.66.2",
-    "rollup-plugin-node-resolve": "^3.4.0",
+    "typescript": "^3.5.3",
+    "rollup": "^1.18.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
-    "uglify-js": "^3.4.9"
+    "uglify-js": "^3.6.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/features/arm-features",
   "repository": {

sdk/features/arm-features/rollup.config.js

@@ -29,7 +29,7 @@ const config = {
  */`
   },
   plugins: [
-    nodeResolve({ module: true }),
+    nodeResolve({ mainFields: ['module', 'main'] }),
     sourcemaps()
   ]
 };

sdk/features/arm-features/src/models/index.ts

@@ -227,6 +227,26 @@ export type FeaturesRegisterResponse = FeatureResult & {
     };
 };
 
+/**
+ * Contains response data for the unregister operation.
+ */
+export type FeaturesUnregisterResponse = FeatureResult & {
+  /**
+   * The underlying HTTP response.
+   */
+  _response: msRest.HttpResponse & {
+      /**
+       * The response body as text (string format)
+       */
+      bodyAsText: string;
+
+      /**
+       * The response body as parsed JSON or XML
+       */
+      parsedBody: FeatureResult;
+    };
+};
+
 /**
  * Contains response data for the listAllNext operation.
  */

sdk/features/arm-features/src/operations/features.ts

@@ -143,6 +143,38 @@ export class Features {
       callback) as Promise<Models.FeaturesRegisterResponse>;
   }
 
+  /**
+   * Unregisters the preview feature for the subscription.
+   * @param resourceProviderNamespace The namespace of the resource provider.
+   * @param featureName The name of the feature to unregister.
+   * @param [options] The optional parameters
+   * @returns Promise<Models.FeaturesUnregisterResponse>
+   */
+  unregister(resourceProviderNamespace: string, featureName: string, options?: msRest.RequestOptionsBase): Promise<Models.FeaturesUnregisterResponse>;
+  /**
+   * @param resourceProviderNamespace The namespace of the resource provider.
+   * @param featureName The name of the feature to unregister.
+   * @param callback The callback
+   */
+  unregister(resourceProviderNamespace: string, featureName: string, callback: msRest.ServiceCallback<Models.FeatureResult>): void;
+  /**
+   * @param resourceProviderNamespace The namespace of the resource provider.
+   * @param featureName The name of the feature to unregister.
+   * @param options The optional parameters
+   * @param callback The callback
+   */
+  unregister(resourceProviderNamespace: string, featureName: string, options: msRest.RequestOptionsBase, callback: msRest.ServiceCallback<Models.FeatureResult>): void;
+  unregister(resourceProviderNamespace: string, featureName: string, options?: msRest.RequestOptionsBase | msRest.ServiceCallback<Models.FeatureResult>, callback?: msRest.ServiceCallback<Models.FeatureResult>): Promise<Models.FeaturesUnregisterResponse> {
+    return this.client.sendOperationRequest(
+      {
+        resourceProviderNamespace,
+        featureName,
+        options
+      },
+      unregisterOperationSpec,
+      callback) as Promise<Models.FeaturesUnregisterResponse>;
+  }
+
   /**
    * Gets all the preview features that are available through AFEC for the subscription.
    * @param nextPageLink The NextLink from the previous successful call to List operation.
@@ -300,6 +332,31 @@ const registerOperationSpec: msRest.OperationSpec = {
   serializer
 };
 
+const unregisterOperationSpec: msRest.OperationSpec = {
+  httpMethod: "POST",
+  path: "subscriptions/{subscriptionId}/providers/Microsoft.Features/providers/{resourceProviderNamespace}/features/{featureName}/unregister",
+  urlParameters: [
+    Parameters.resourceProviderNamespace,
+    Parameters.featureName,
+    Parameters.subscriptionId
+  ],
+  queryParameters: [
+    Parameters.apiVersion
+  ],
+  headerParameters: [
+    Parameters.acceptLanguage
+  ],
+  responses: {
+    200: {
+      bodyMapper: Mappers.FeatureResult
+    },
+    default: {
+      bodyMapper: Mappers.CloudError
+    }
+  },
+  serializer
+};
+
 const listAllNextOperationSpec: msRest.OperationSpec = {
   httpMethod: "GET",
   baseUrl: "https://management.azure.com",

sdk/features/arm-features/tsconfig.json

@@ -9,7 +9,7 @@
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
-    "lib": ["es6"],
+    "lib": ["es6", "dom"],
     "declaration": true,
     "outDir": "./esm",
     "importHelpers": true