Skip to content

Commit

Permalink
[Microsoft.DeviceUpdate] Private Link - Added Network RP required pro…
Browse files Browse the repository at this point in the history
…perties (Azure#17042)

* Added group IDs array to PrivateEndpointConnection in v4 common type

* Added private endpoint connections to the top level resource

* Updated examples

* Added types.json to commopn-types/v4

* Moved new version of privatelinks.json into our directory

* Wrong level

* Added period to the end of description for consistency

* Updated version in privatelinks.json

* Removed duplicate resource from privatelinks.json

* Made PrivateEndpointConnection.properties required, added PEC payload to examples

* Added Operations List example

* Referenced Operations example file from the swagger

* Reduce number of operations in the Operations_List example

* Fixed Operations List example

* Removed PrivateEnpointConnection from Account update example
  • Loading branch information
darkoa-msft authored Dec 13, 2021
1 parent 39a4d73 commit 6654157
Show file tree
Hide file tree
Showing 10 changed files with 337 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@
"200": {
"description": "The request was successful; the request was well-formed and received properly.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnectionListResult"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnectionListResult"
}
},
"default": {
Expand Down Expand Up @@ -716,14 +716,14 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
}
],
"responses": {
"200": {
"description": "The request was successful; the request was well-formed and received properly.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
},
"default": {
Expand Down Expand Up @@ -759,23 +759,23 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
},
{
"name": "privateEndpointConnection",
"in": "body",
"description": "The parameters for creating a private endpoint connection.",
"required": true,
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
}
],
"responses": {
"201": {
"description": "The request was successful; the operation will complete asynchronously.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
},
"default": {
Expand Down Expand Up @@ -815,7 +815,7 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
}
],
"responses": {
Expand Down Expand Up @@ -1207,6 +1207,11 @@
"deprecated": false,
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"Gets list of Operations": {
"$ref": "./examples/Operations_List.json"
}
}
}
}
Expand Down Expand Up @@ -1249,7 +1254,7 @@
"readOnly": true
},
"publicNetworkAccess": {
"description": "Whether or not public network access is allowed for the container registry.",
"description": "Whether or not public network access is allowed for the account.",
"default": "Enabled",
"enum": [
"Enabled",
Expand All @@ -1260,6 +1265,13 @@
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"privateEndpointConnections": {
"description": "List of private endpoint connections associated with the account.",
"type": "array",
"items": {
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
}
}
},
Expand Down Expand Up @@ -1489,7 +1501,7 @@
"type": "object",
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkResourceProperties"
"$ref": "./privatelinks.json#/definitions/PrivateLinkResourceProperties"
}
],
"properties": {
Expand Down Expand Up @@ -1636,7 +1648,7 @@
},
"remotePrivateLinkServiceConnectionState": {
"description": "Remote private link service connection state",
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState"
"$ref": "./privatelinks.json#/definitions/PrivateLinkServiceConnectionState"
},
"remotePrivateEndpointConnection": {
"description": "Remote private endpoint connection details.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Accepted",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": []
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
}
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
},
"tags": {
"tagKey": "tagValue"
Expand All @@ -39,7 +60,28 @@
},
"properties": {
"provisioningState": "Created",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
},
"tags": {
"tagKey": "tagValue"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"api-version": "2020-03-01-preview"
},
"responses": {
"200": {
"body": {
"nextLink": "string",
"value": [
{
"name": "Microsoft.DeviceUpdate/accounts/read",
"isDataAction": false,
"display": {
"provider": "Microsoft.DeviceUpdate",
"resource": "Device Update Account",
"operation": "Get/List Accounts",
"description": "Returns the list of Device Update Accounts"
}
},
{
"name": "Microsoft.DeviceUpdate/accounts/write",
"isDataAction": false,
"display": {
"provider": "Microsoft.DeviceUpdate",
"resource": "Device Update Account",
"operation": "Create/Update Account",
"description": "Creates or updates a Device Update Account"
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
]
Expand Down
Loading

0 comments on commit 6654157

Please sign in to comment.