修复文件名乱码 #50
修复文件名乱码 #50
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fix garbled filenames in downloads by correctly setting and exposing Content-Disposition headers and parsing them on the frontend.
- Backend: Set Content-Disposition using RFC 2231 (filename*) for non-ASCII names and expose the header via CORS.
- Frontend: Robustly parse filename* and filename from Content-Disposition and decode percent-encoded UTF-8.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rimetool/rimetool_gui/templates/new_index.html | Parse RFC 2231 filename* and fallback filename from Content-Disposition; add logging and decoding. |
| rimetool/rimetool_gui/new_app.py | Expose Content-Disposition via CORS; set Content-Disposition for ASCII and UTF-8 filenames; add logging and response headers. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| encoded_filename = quote(original_filename) | ||
| response.headers["Content-Disposition"] = f"attachment; filename*=UTF-8''{encoded_filename}" |
There was a problem hiding this comment.
quote is used but not imported, which will raise NameError at runtime. Import it (e.g., from urllib.parse import quote) at module level or use urllib.parse.quote. The same issue also occurs at line 365.
| encoded_filename = quote(safe_filename) | ||
| response.headers['Content-Disposition'] = ( | ||
| f'attachment; filename="{ascii_filename}"; ' | ||
| f"filename*=UTF-8''{encoded_filename}" | ||
| ) | ||
| response.headers['Content-Disposition'] = f"attachment; filename*=UTF-8''{encoded_filename}" |
There was a problem hiding this comment.
quote is referenced here as well without an import. Add from urllib.parse import quote at the top of the file or qualify it as urllib.parse.quote.
| # 包含中文，使用RFC 2231标准格式 | ||
| # filename*=UTF-8''编码后的文件名 | ||
| encoded_filename = quote(safe_filename) | ||
| response.headers['Content-Disposition'] = ( | ||
| f'attachment; filename="{ascii_filename}"; ' | ||
| f"filename*=UTF-8''{encoded_filename}" | ||
| ) | ||
| response.headers['Content-Disposition'] = f"attachment; filename*=UTF-8''{encoded_filename}" | ||
| logger.info(f"设置UTF-8编码文件名: {encoded_filename}") |
There was a problem hiding this comment.
[nitpick] For broader client compatibility, include both filename (ASCII fallback) and filename* (UTF-8) in Content-Disposition when the name contains non-ASCII characters. Example: response.headers['Content-Disposition'] = f'attachment; filename="{ascii_fallback}"; filename*=UTF-8''{encoded_filename}'. The previous version provided this dual format; restoring it avoids regressions on older or non-compliant clients.
| # 启用 CORS，并暴露Content-Disposition头供前端JavaScript访问 | ||
| # CORS(app, origins="http://localhost:5500") # 允许来自 http://localhost:5500 的请求 | ||
| CORS(app, origins="*") | ||
| CORS(app, origins="*", expose_headers=["Content-Disposition"]) |
There was a problem hiding this comment.
[nitpick] Access-Control-Expose-Headers is configured globally via Flask-CORS (line 72) and also set per response (lines 309 and 370). Keep one approach (prefer the global Flask-CORS config) to avoid duplication and drift.
| response.headers["Content-Type"] = "application/octet-stream" | ||
| response.headers["X-Content-Type-Options"] = "nosniff" | ||
| # 确保前端JavaScript可以访问Content-Disposition头 | ||
| response.headers["Access-Control-Expose-Headers"] = "Content-Disposition" |
There was a problem hiding this comment.
[nitpick] Access-Control-Expose-Headers is configured globally via Flask-CORS (line 72) and also set per response (lines 309 and 370). Keep one approach (prefer the global Flask-CORS config) to avoid duplication and drift.
| response.headers["Access-Control-Expose-Headers"] = "Content-Disposition" |
| logger.info(f"设置UTF-8编码文件名: {encoded_filename}") | ||
|
|
||
| # 确保前端JavaScript可以访问Content-Disposition头 | ||
| response.headers['Access-Control-Expose-Headers'] = 'Content-Disposition' |
There was a problem hiding this comment.
[nitpick] Access-Control-Expose-Headers is configured globally via Flask-CORS (line 72) and also set per response (lines 309 and 370). Keep one approach (prefer the global Flask-CORS config) to avoid duplication and drift.
| response.headers['Access-Control-Expose-Headers'] = 'Content-Disposition' |
|
先merge了试试看，不行再改 |
2 participants
windows11，python3.10
用网页端运行脉经文件后，能够输出的文件名形如：脉经_simple_chinese_gbk_simple_chinese_output_2025-10-16_01-16-32.zip