-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LMAS 2.0.0: Update to DSL2 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to main
…rt. First draft conversion done
…ompleted successfully by checking that report file exists
cimendes
changed the title
LMAS release 2.0.0: Update to DSL2
LMAS 2.0.0: Update to DSL2
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#LMAS 2.0.0
✨ This PR updates LMAS to Nextflow DSL2. ✨
This is in preparation for the new release. LMAS has been updated to version 2.0.0
Main changes
This PR implements the following changes.
DSL2
The LMAS workflow now enables Nextflow DSL2. The main script has been broken into the following modules:
LMAS script
The main command to run the main script
main.nf
with nextflow has been wrapped into anLMAS
bash script to facilitate usage. Now LMAS can be simply called withIf no options are provided it simply prints out the help message.
Documentation
All documentation has been updated, both in the repository and in readthedocs, to reflect the new changes. Instructions on how to add a new assembler have been updated to nextflow DSL2. Documentation has also been updated to include the ABySS and MetaHipMEr2 assemblers.
Tests
The workflow sanity test has been updated to ensure that the workflow finishes successfully by searching for the final report file.