-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to list *v1alpha1.NiFiFn: nififns.nififn.nifi-stateless.b23.io is forbidden #8
Comments
Thanks for taking an interest in this project! Unfortunately, I won't have time to look into this bug in the near term but I would be happy to review a PR or any additional info if you'd like to dig into it. The RBAC roles are generated from the kubebuilder annotations here: https://github.com/b23llc/nifi-stateless-operator/blob/master/controllers/nififn_controller.go#L17-L20 You can regenerate the roles and rolebindings with the command: |
@dbkegley - Thank you for taking the time to respond to the issue, I was able to fix the issue based on your response. Please review the commit linked above, if you are ok with the changes, I will raise a PR. PS: I also have some changes to make flowFiles optional and support pulling images from a private repository by way of image pull secrets. I will push those in a separate commit. |
@nagwanidheeraj That looks good to me, thanks for looking into this! I'll test the PR when it's posted Out of curiosity, what's the motivation behind making flowfiles optional? I'm not opposed, just wondering what your use case is and how you plan to enqueue flowfiles if none are provided at runtime |
@dbkegley - Raised the PR
Most of the use cases I have are where the data is coming from external sources like s3. We start with the ListS3 bucket processor and go from there. This is true for a majority of our use cases with s3 being the main source, and some are also based on GCS/Kafka/SQS and such. No NiFi flow that we have requires an input file, yet. Is there a way we can chat further about the changes I'm planning over an email? My email address is listed on my profile and would love to pick your brain. |
Absolutely, feel free to shoot me an email at kegs@b23.io One thing that I want to mention here in case others are interested is that there is currently a requirement in nifi-stateless imposed here and here which will fail initialization if there is not exactly one input port at the root level of the flow. I have some initial thoughts on this and a very similar use case to yours but I haven't proposed them in the nifi developer list yet. I was planning to wait until after the first official release of nifi-stateless in nifi-1.10 |
Those requirements mean:
I was able to run a flow on EKS that has no input ports and no flow files specified in the NiFiFn yaml. Flow executed successfully and was able to copy a file from one folder to another in a s3 bucket. |
You can build the enhancements branch in my fork and try it out yourself. It's been tested to see if it works. |
Ah, you're right. I hadn't actually tested it, that's just what I remembered from looking through the nifi-stateless code previously. In that case I agree that the flow_files attribute should be optional for the operator |
@nagwanidheeraj which image you used for this? I want to run flow without input ports |
Followed the readme.md instructions and configured nifi-stateless-operator on an AWS EKS Cluster.
When I see the logs for the manager, I see this:
kubectl -n nifi-stateless-operator-system logs nifi-stateless-operator-controller-manager-64b64fb5d6-9rz9k manager
The text was updated successfully, but these errors were encountered: