-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage basket addition from Alias #382 #1021
Conversation
Let's just edit the Rather than creating a whole new admin page |
Feedbacks made on Discord |
src/routes/(app)/admin[[hash=admin_hash]]/retail-cart/+page.server.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM as it is, if current version is ok with @Tirodem , ok to merge (after applying suggestions)
Unless I missed something, not OK with this version. |
Need to customize as mentioned in #1021 (comment) |
src/routes/(app)/cart/+page.svelte
Outdated
return; | ||
} | ||
await invalidate(UrlDependency.Cart); | ||
document.body.scrollIntoView(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure about this one, this scrolls up.
It was necessary when adding to cart in case to show the popup. But there's no popup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me (after removing body.scrollIntoView())
If code works for @Tirodem
OK for me. |
Manage basket addition from Alias #382