Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 LN orders with phoenixd don't seem to expire #1591 #1642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 LN orders with phoenixd don't seem to expire #1591 #1642

wants to merge 1 commit into from

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 11, 2024

No description provided.

@ithiame ithiame linked an issue Dec 11, 2024 that may be closed by this pull request
🐛 LN orders with phoenixd don't seem to expire #1591
Open
coyotte508
coyotte508 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah maybe phoenixd's api changed

@ithiame
Copy link
Contributor Author

ithiame commented Dec 11, 2024

The response still has completedAt

{
    "paymentHash": "f419207c9edde9021ebfb6bd0df6bd0a6606ecaf935357cc2f362e30835c3765",
    "preimage": "8d2f7d277f67ed003e2f01ab15d9bc1df9d928bf6aff0f8cc48e3feb45babe6d",
    "externalId": "foobar",
    "description": "my first invoice",
    "invoice": "lntb1u1pjlsjnqpp57svjqly7mh5sy84lk67sma4apfnqdm90jdf40np0xchrpq6uxajscqpjsp592kp0fs2ssgpq9h54tsfaj5w34287v8fezgaw6cr56f076c05glq9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdq6d4ujqenfwfehggrfdemx76trv5mqz9grzjqwfn3p9278ttzzpe0e00uhyxhned3j5d9acqak5emwfpflp8z2cnflcyamh4dcuhwqqqqqlgqqqqqeqqjqnjpjvnv0p3wvwc6vhzkkgm8kl9r837x4p9qupk5ln5tqlm7prrlsy5xd8cf5agae64f53dvm9el0z5hvgcnta4stgmrg7zwfah0nqrqph4ts8l",
    "isPaid": false,
    "receivedSat": 0,
    "fees": 0,
    "completedAt": null,
    "createdAt": 1710770784837
}

@coyotte508
Copy link
Collaborator

coyotte508 commented Dec 11, 2024 •
edited
Loading

so I don't understand why the .optional() instead of .nullable() in the PR? Does the response change for expired invoices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 LN orders with phoenixd don't seem to expire
2 participants
@ithiame @coyotte508