Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT-12847] Fix BGT JNDI connection gebruik voor Oracle/MSSQL #1199

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

matthijsln
Copy link
Member

@matthijsln matthijsln commented Oct 28, 2021

Voor Oracle en MS SQL was de database verbinding niet beschikbaar waardoor schema aanmaken en laden alleen met default password kon (en in voorkomende gevallen mislukte).

resolves SUPPORT-12847

@matthijsln matthijsln requested a review from mprins October 28, 2021 12:14
@mprins mprins added this to the 2.1.1 milestone Oct 28, 2021
@mprins mprins changed the title [SUPPORT-12847] Fix BGT connection from JNDI not used for Oracle/MSSQL [SUPPORT-12847] Fix BGT JNDI connection gebruik voor Oracle/MSSQL Oct 28, 2021
@mprins mprins enabled auto-merge October 28, 2021 13:00
@mprins mprins merged commit 385d34f into master Oct 28, 2021
@mprins mprins deleted the bugfix/support-12847-oracle-bgt-jndi branch October 28, 2021 13:55
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1199 (30c5fcf) into master (3e2cd14) will decrease coverage by 0.00%.
The diff coverage is 29.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1199      +/-   ##
============================================
- Coverage     36.22%   36.22%   -0.01%     
  Complexity      809      809              
============================================
  Files           380      380              
  Lines         17329    17324       -5     
  Branches       1715     1710       -5     
============================================
- Hits           6277     6275       -2     
+ Misses        10511    10506       -5     
- Partials        541      543       +2     
Impacted Files Coverage Δ
...in/java/nl/b3p/brmo/service/scanner/BGTLoader.java 0.00% <0.00%> (ø)
.../main/java/nl/b3p/brmo/bgt/loader/BGTDatabase.java 63.44% <38.88%> (-5.61%) ⬇️
...nl/b3p/brmo/bgt/download/api/DownloadApiUtils.java 67.64% <0.00%> (-8.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2cd14...30c5fcf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants