Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRMO-186] Fix BGT updates for Oracle because table_prefix saved as '' is changed to NULL when reading back #1436

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

matthijsln
Copy link
Member

@mprins mprins enabled auto-merge June 2, 2022 16:41
@mprins mprins merged commit abba77b into master Jun 2, 2022
@mprins mprins deleted the bugfix/BRMO-186-oracle-fix-bgt-updates branch June 2, 2022 17:09
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1436 (fc40570) into master (9de9939) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master    #1436    +/-   ##
==========================================
  Coverage     35.88%   35.89%            
- Complexity      809     1190   +381     
==========================================
  Files           410      410            
  Lines         19194    19194            
  Branches       1914     1914            
==========================================
+ Hits           6888     6889     +1     
  Misses        11704    11704            
+ Partials        602      601     -1     
Impacted Files Coverage Δ
...va/nl/b3p/brmo/bgt/loader/cli/DownloadCommand.java 63.11% <100.00%> (ø)
...nl/b3p/brmo/util/http/HttpSeekableByteChannel.java 69.87% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de9939...fc40570. Read the comment docs.

@mprins mprins changed the title Fix BGT updates for Oracle because table_prefix saved as '' is changed to NULL when reading back [BRMO-186] Fix BGT updates for Oracle because table_prefix saved as '' is changed to NULL when reading back Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants