Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRMO-223] Add last-byte-pos to Range header to fix PDOK partial download #1595

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[BRMO-223] Add last-byte-pos to Range header to fix PDOK partial download #1595

merged 1 commit into from
Nov 22, 2022

Conversation

matthijsln
Copy link
Member

No description provided.

@matthijsln
[BRMO-223] Add last-byte-pos to Range header, otherwise Windows-Azure…
49c05fb 
…-Blob/1.0 Microsoft-HTTPAPI/2.0 won't send partial content
@matthijsln matthijsln requested a review from mprins November 22, 2022 16:17
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #1595 (49c05fb) into master (271de1e) will increase coverage by 1%.
The diff coverage is 80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #1595    +/-   ##
=========================================
+ Coverage        36%     36%    +1%     
- Complexity      808    1181   +373     
=========================================
  Files           410     410            
  Lines         19316   19319     +3     
  Branches       1918    1919     +1     
=========================================
+ Hits           6877    6880     +3     
  Misses        11828   11828            
  Partials        611     611
Impacted Files Coverage Δ
...nl/b3p/brmo/util/http/HttpSeekableByteChannel.java 70% <ø> (+2%) ⬆️
...o/util/http/HttpStartRangeInputStreamProvider.java 90% <80%> (-1%) ⬇️

@mprins mprins added this to the 2.3.3 milestone Nov 22, 2022
mprins
mprins approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mprins mprins merged commit 759d0d7 into master Nov 22, 2022
@mprins mprins deleted the http-range-request-add-last-byte-pos branch November 22, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprins mprins mprins approved these changes

Assignees
No one assigned
Labels
BGT bug
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@matthijsln @mprins