add git diff check (#730)

* add git diff check

.github/workflows/pytest_asdf.yml

@@ -14,15 +14,33 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0 # Fetch all history for all tags and branches
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
       - uses: actions/setup-python@v3
         with:
           python-version: '3.10'
+      - uses: actions/cache@v3
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('setup.cfg') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
       - name: pip installs
         run: |
           pip install -e .[test]
       - name: run asdf schema pytest
         run: |
           pytest --asdf-tests --ignore=weldx/tests/ --no-cov weldx/schemas/
+      - name: check manifest diff
+        if: always()
+        run: |
+          cd ./devtools/scripts/
+          python ./update_manifest.py
+      - name: git diff
+        if: always()
+        run: |
+          git diff --color --exit-code
+
 
   validate_manifest:
     name: validate weldx manifest
@@ -32,9 +50,15 @@ jobs:
       - uses: actions/setup-python@v3
         with:
           python-version: '3.10'
+      - uses: actions/cache@v3
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-0
+          restore-keys: |
+            ${{ runner.os }}-pip-
       - name: pip installs
         run: |
-          python -m pip install git+https://github.com/asdf-format/asdf.git
+          pip install asdf>=2.10
       - uses: jannekem/run-python-script-action@v1
         with:
           script: |

devtools/scripts/update_manifest.py

@@ -1,3 +1,4 @@
+"""Update the manifest file with schema files found in this directory."""
 from pathlib import Path
 
 import yaml
@@ -31,7 +32,7 @@ def update_manifest(
         if mapping["schema_uri"].startswith("http://stsci.edu/schemas")
     ]
 
-    schemas = Path(search_dir).rglob("*.yaml")
+    schemas = sorted(Path(search_dir).rglob("*.yaml"))
 
     for schema in schemas:
         content = yaml.load(
@@ -52,7 +53,7 @@ def update_manifest(
             else:
                 print(f"No converter for URI: {schema}")
 
-    with open(Path(out), "w") as outfile:
+    with open(Path(out), "w") as outfile:  # skipcq: PTC-W6004
         outfile.write("%YAML 1.1\n---\n")
         yaml.dump(
             manifest,

weldx/manifests/weldx-0.1.1.yaml

@@ -7,8 +7,6 @@ description: Manifest listing all tag URIs with schema URIs supported by weldx
 tags:
 - tag_uri: tag:stsci.edu:asdf/unit/quantity-1.1.0
   schema_uri: http://stsci.edu/schemas/asdf/unit/quantity-1.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/uuid-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/uuid-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/base_metal-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/base_metal-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/connection-0.1.0
@@ -17,10 +15,10 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/joint_penetration-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/sub_assembly-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/sub_assembly-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/weldment-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/weldment-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/weld_details-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/weld_details-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/weldment-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/weldment-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/design/workpiece-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/design/workpiece-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/process/arc_welding_process-0.1.0
@@ -31,10 +29,10 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/process/shielding_gas_for_procedure-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/aws/process/shielding_gas_type-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/aws/process/shielding_gas_type-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/dataset-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/dataset-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/data_array-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/data_array-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/dataset-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/dataset-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/dimension-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/dimension-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/file-0.1.0
@@ -43,16 +41,6 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/generic_series-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/generic_series_free_dimension-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/generic_series_free_dimension-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/mathematical_expression-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/mathematical_expression-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/time_series-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/time_series-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/time_series-0.1.1
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/time_series-0.1.1
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/variable-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/variable-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/core/variable-0.1.1
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/variable-0.1.1
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/geometry/spatial_data-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/geometry/spatial_data-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/geometry/spatial_data-0.1.1
@@ -63,12 +51,22 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/graph/di_graph-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/graph/di_node-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/graph/di_node-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/mathematical_expression-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/mathematical_expression-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/time_series-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/time_series-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/time_series-0.1.1
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/time_series-0.1.1
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/transformations/coordinate_system_hierarchy-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/transformations/coordinate_system_hierarchy-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/transformations/local_coordinate_system-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/transformations/local_coordinate_system-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/core/transformations/rotation-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/core/transformations/rotation-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/variable-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/variable-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/core/variable-0.1.1
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/core/variable-0.1.1
 - tag_uri: asdf://weldx.bam.de/weldx/tags/debug/test_property_tag-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/debug/test_property_tag-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/debug/test_shape_validator-0.1.0
@@ -113,12 +111,12 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/measurement/signal_transformation-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/measurement/source-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/measurement/source-0.1.0
-- tag_uri: asdf://weldx.bam.de/weldx/tags/process/GMAW-0.1.0
-  schema_uri: asdf://weldx.bam.de/weldx/schemas/process/GMAW-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/process/CLOOS/pulse-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/process/CLOOS/pulse-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/process/CLOOS/spray_arc-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/process/CLOOS/spray_arc-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/process/GMAW-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/process/GMAW-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/time/datetimeindex-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/time/datetimeindex-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/time/time-0.1.0
@@ -133,4 +131,6 @@ tags:
   schema_uri: asdf://weldx.bam.de/weldx/schemas/units/quantity-0.1.0
 - tag_uri: asdf://weldx.bam.de/weldx/tags/units/units-0.1.0
   schema_uri: asdf://weldx.bam.de/weldx/schemas/units/units-0.1.0
+- tag_uri: asdf://weldx.bam.de/weldx/tags/uuid-0.1.0
+  schema_uri: asdf://weldx.bam.de/weldx/schemas/uuid-0.1.0
 ...