You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can deprecate the transformations.rotation_matrix_* functions in favor of WXRotation.as_matrix to allow more input options and clean up the API a bit
They are mostly used for testing
The text was updated successfully, but these errors were encountered:
For the aid of deprecating funtions, at least in my experience, a deprecation class/function decorator is very useful. It shows a warning indicating that the called object is deprecated and can be turned into a an error via the warnings module to clean up all usages within the code base. Users will just see the warning for a couple of versions and can adopt their code accordingly.
Back to topic, I agree that these functions are a indeed a duplication of features and should be replaced by scipy Rotations.
Since we are the only users so far, I think we can just remove it. However, having a deprecated decorator is probably a nice thing for the future. I'll add one...
I think we can deprecate the
transformations.rotation_matrix_*
functions in favor ofWXRotation.as_matrix
to allow more input options and clean up the API a bitThey are mostly used for testing
The text was updated successfully, but these errors were encountered: