Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation decorator #295

Merged
merged 7 commits into from
Mar 25, 2021

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Mar 22, 2021

Changes

Add a decorator to mark functions as deprecated

Related Issues

#294

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@vhirtham vhirtham added feature new API features deprecation function or dependency deprecations labels Mar 22, 2021
@vhirtham vhirtham self-assigned this Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #295 (9f09f8a) into master (efb6bac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          77       77           
  Lines        4119     4135   +16     
=======================================
+ Hits         4104     4120   +16     
  Misses         15       15           
Impacted Files Coverage Δ
weldx/util.py 99.69% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb6bac...9f09f8a. Read the comment docs.

@vhirtham
Copy link
Collaborator Author

Alternatively, we can use the deprecation package which is a better solution I guess.

weldx/util.py Outdated Show resolved Hide resolved
weldx/util.py Outdated Show resolved Hide resolved
weldx/util.py Outdated Show resolved Hide resolved
Copy link
Contributor

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@vhirtham vhirtham merged commit 529ced9 into BAMWelDX:master Mar 25, 2021
@vhirtham vhirtham deleted the 294_deprecation_decorator branch March 25, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation function or dependency deprecations feature new API features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants