Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataclass check decorator #179

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Dataclass check decorator #179

merged 5 commits into from
Oct 29, 2020

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Oct 27, 2020

Changes

Add a decorator that enables pint dimension checks for @dataclass objects

Related Issues

Closes # (add issue numbers)

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added the units unit handling and pint label Oct 27, 2020
@CagtayFabry CagtayFabry self-assigned this Oct 27, 2020
@CagtayFabry CagtayFabry marked this pull request as ready for review October 27, 2020 21:09
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #179 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          63       63           
  Lines        3638     3659   +21     
=======================================
+ Hits         3628     3649   +21     
  Misses         10       10           
Impacted Files Coverage Δ
weldx/asdf/tags/weldx/core/iso_groove.py 100.00% <100.00%> (ø)
weldx/utility.py 98.59% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3413dc9...1fb9984. Read the comment docs.

weldx/utility.py Outdated Show resolved Hide resolved
@CagtayFabry CagtayFabry requested a review from vhirtham October 29, 2020 09:55
weldx/utility.py Outdated Show resolved Hide resolved
Co-authored-by: vhirtham <volker.hirthammer@bam.de>
@CagtayFabry CagtayFabry merged commit 5549075 into master Oct 29, 2020
@CagtayFabry CagtayFabry deleted the dataclass_check_decorator branch October 29, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
units unit handling and pint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants