Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't store time dependent LCS coordinates inline #222

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Dec 17, 2020

Changes

  • time dependent LCS coords no longer stored inline

Related Issues

Closes # (add issue numbers)

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added bug Something isn't working ASDF everything ASDF related (python + schemas) labels Dec 17, 2020
@CagtayFabry CagtayFabry self-assigned this Dec 17, 2020
@CagtayFabry
Copy link
Member Author

seems like I missed this in #177 @vhirtham

@CagtayFabry CagtayFabry marked this pull request as ready for review December 17, 2020 16:27
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #222 (7a27d74) into master (7456171) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          69       69           
  Lines        3850     3851    +1     
=======================================
+ Hits         3840     3841    +1     
  Misses         10       10           
Impacted Files Coverage Δ
...dx/core/transformations/local_coordinate_system.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7456171...472b9c3. Read the comment docs.

@CagtayFabry CagtayFabry merged commit 0a864d5 into master Dec 17, 2020
@CagtayFabry CagtayFabry deleted the fix_coord_inline branch December 17, 2020 16:50
@CagtayFabry CagtayFabry added this to the 0.3.0 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant