Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plot and rasterize functions #223

Merged
merged 10 commits into from
Dec 22, 2020
Merged

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Dec 18, 2020

Changes

  • geometry.Profile.rasterize can return list of rasterized shapes
  • geometry.Profile.plot plots individual line objects for each shape (instead of a single line object)

Related Issues

Closes # (add issue numbers)

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #223 (2dbad49) into master (0a864d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          69       69           
  Lines        3851     3856    +5     
=======================================
+ Hits         3841     3846    +5     
  Misses         10       10           
Impacted Files Coverage Δ
weldx/geometry.py 100.00% <100.00%> (ø)
weldx/transformations.py 99.38% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a864d5...2dbad49. Read the comment docs.

@CagtayFabry CagtayFabry changed the title Update plot functions update plot and rasterize functions Dec 18, 2020
@CagtayFabry CagtayFabry requested a review from vhirtham December 18, 2020 15:59
@CagtayFabry CagtayFabry marked this pull request as ready for review December 18, 2020 15:59
@CagtayFabry
Copy link
Member Author

thanks for looking over this @vhirtham 🚀
I realized later I could probably just loop over the shapes in my code just as well.. 😄 But it simplifies things a bit

We can take a more in-depth look at this in #197 again

@CagtayFabry CagtayFabry merged commit 51b62ab into master Dec 22, 2020
@CagtayFabry CagtayFabry deleted the update_plot_functions branch December 22, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants