Add from_file and write_to_file to SpatialData

[vhirtham]

Changes

• add meshio as new dependency
• add from_file and write_to_file to SpatialData

Checks

• updated CHANGELOG.md
• updated tests
• updated doc/
• update example/tutorial notebooks

[codecov]

Codecov Report

Merging #265 (551e104) into master (2bda4dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          75       75           
  Lines        4009     4019   +10     
=======================================
+ Hits         3995     4005   +10     
  Misses         14       14           

Impacted Files	Coverage Δ
weldx/geometry.py	99.39% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175b227...551e104. Read the comment docs.

[CagtayFabry]

pathlib.Path also seems to be supported by meshio so we might add that to the type hints

[vhirtham]

yes. I am currently experimenting with it and writing the test ;)

[CagtayFabry]

I don't think a test is necessary here actually since this is such a thin wrapping, I would be fine with #noqa as well 😉

[vhirtham]

It's already there and it actually found a bug in the write_to_file :p

[marscher]

It looks like the library is leaking file handles. But by using a sane OS this ain't a problem :p

[CagtayFabry]

@vhirtham I stumbled upon this nice utility in meshio that might come in handy for other file operations later, just dropping it here :)

[marscher]

LGTM!

[marscher]

@vhirtham I stumbled upon this nice utility in meshio that might come in handy for other file operations later, just dropping it here :)

This is actually meant to be used when using their readers/writers to avoid leaking file handles!

[pep8speaks]

Hello @vhirtham! Thanks for updating this PR.

• In the file tests/test_geometry.py:

Line 6:13: E261 at least two spaces before inline comment
Line 7:31: E261 at least two spaces before inline comment
Line 8:16: E261 at least two spaces before inline comment
Line 11:67: E202 whitespace before ')'
Line 13:1: E128 continuation line under-indented for visual indent
Line 15:23: E999 SyntaxError: invalid syntax
Line 16:5: E113 unexpected indentation
Line 17:9: E128 continuation line under-indented for visual indent
Line 18:9: E128 continuation line under-indented for visual indent
Line 27:1: E302 expected 2 blank lines, found 1
Line 47:89: E501 line too long (96 > 88 characters)
Line 56:1: E302 expected 2 blank lines, found 1
Line 63:89: E501 line too long (105 > 88 characters)
Line 66:24: E201 whitespace after '{'
Line 68:89: E501 line too long (97 > 88 characters)
Line 84:89: E501 line too long (98 > 88 characters)
Line 87:1: E302 expected 2 blank lines, found 1
Line 102:89: E501 line too long (96 > 88 characters)
Line 110:1: E302 expected 2 blank lines, found 1
Line 118:89: E501 line too long (120 > 88 characters)
Line 120:89: E501 line too long (113 > 88 characters)
Line 128:89: E501 line too long (103 > 88 characters)
Line 130:89: E501 line too long (96 > 88 characters)
Line 132:89: E501 line too long (103 > 88 characters)
Line 134:89: E501 line too long (96 > 88 characters)
Line 136:89: E501 line too long (97 > 88 characters)
Line 140:89: E501 line too long (107 > 88 characters)
Line 153:1: E305 expected 2 blank lines after class or function definition, found 1
Line 156:18: E261 at least two spaces before inline comment