Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check groove parameters #306

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Mar 27, 2021

Changes

prevent negative IsoBaseGroove parameters

Related Issues

Closes #305

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry self-assigned this Mar 27, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 27, 2021

Hello @CagtayFabry! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-29 07:41:09 UTC

@CagtayFabry
Copy link
Member Author

can you think of any specific groove types that might require negative parameters @mark141 ?
We could implement special __post_init__ functions for those

@CagtayFabry CagtayFabry requested a review from mark141 March 27, 2021 12:41
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #306 (eb23f07) into master (616584b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          77       77           
  Lines        4135     4139    +4     
=======================================
+ Hits         4120     4124    +4     
  Misses         15       15           
Impacted Files Coverage Δ
weldx/welding/groove/iso_9692_1.py 99.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616584b...eb23f07. Read the comment docs.

@CagtayFabry CagtayFabry added this to the 0.3.2 milestone Mar 27, 2021
@CagtayFabry CagtayFabry requested a review from vhirtham March 28, 2021 21:37
@CagtayFabry
Copy link
Member Author

I think the AppVeyor build because I accidentally pushed the branch here isntead of my fork

@vhirtham
Copy link
Collaborator

I think the AppVeyor build because I accidentally pushed the branch here isntead of my fork

Appveyor fails because there is a merge conflict with the master branch (changelog) ;)

@CagtayFabry CagtayFabry merged commit 7f015c0 into BAMWelDX:master Mar 29, 2021
@CagtayFabry CagtayFabry deleted the check_groove_parameters branch March 29, 2021 07:52
@CagtayFabry
Copy link
Member Author

I think the AppVeyor build because I accidentally pushed the branch here isntead of my fork

Appveyor fails because there is a merge conflict with the master branch (changelog) ;)

ahh I see
thanks for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

negative parameters for welding groove shapes
3 participants