-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check groove parameters #306
Check groove parameters #306
Conversation
Hello @CagtayFabry! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-29 07:41:09 UTC |
can you think of any specific groove types that might require negative parameters @mark141 ? |
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 77 77
Lines 4135 4139 +4
=======================================
+ Hits 4120 4124 +4
Misses 15 15
Continue to review full report at Codecov.
|
I think the AppVeyor build because I accidentally pushed the branch here isntead of my fork |
Appveyor fails because there is a merge conflict with the master branch (changelog) ;) |
…ters # Conflicts: # CHANGELOG.md
ahh I see |
Changes
prevent negative
IsoBaseGroove
parametersRelated Issues
Closes #305
Checks