Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update schema descriptions #308

Merged
merged 4 commits into from
Mar 29, 2021
Merged

update schema descriptions #308

merged 4 commits into from
Mar 29, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Mar 28, 2021 •
edited
Loading

Changes

Expand the description fields of the single-pass-weldx.1.0.0.schema

Related Issues

Closes #301

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added this to the 0.3.2 milestone Mar 28, 2021
@CagtayFabry CagtayFabry self-assigned this Mar 28, 2021
@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) documentation Improvements or additions to documentation labels Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021 •
edited
Loading

Codecov Report

Merging #308 (732c037) into master (7f015c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          77       77           
  Lines        4139     4139           
=======================================
  Hits         4124     4124           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f015c0...732c037. Read the comment docs.

@CagtayFabry CagtayFabry marked this pull request as ready for review March 28, 2021 21:45
AndreasPittner
AndreasPittner approved these changes Mar 29, 2021
View reviewed changes
Copy link

@AndreasPittner AndreasPittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These detailed description allows to follow workflow to setup the welding example easily and directly.

@CagtayFabry CagtayFabry merged commit be91707 into BAMWelDX:master Mar 29, 2021
@CagtayFabry CagtayFabry deleted the update_single_weld_pass_schema branch March 29, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasPittner AndreasPittner AndreasPittner approved these changes

Assignees

@CagtayFabry CagtayFabry

Labels
ASDF everything ASDF related (python + schemas) documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.

expand single_pass_weld-1.0.0 schema description
2 participants
@CagtayFabry @AndreasPittner