Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs build failing #332

Merged
merged 6 commits into from
Apr 7, 2021
Merged

fix docs build failing #332

merged 6 commits into from
Apr 7, 2021

Conversation

CagtayFabry
Copy link
Member

not sure why docs builds are failing suddenly so testing some older versions

@CagtayFabry CagtayFabry added bug Something isn't working documentation Improvements or additions to documentation CI labels Apr 6, 2021
@CagtayFabry CagtayFabry self-assigned this Apr 6, 2021
@CagtayFabry CagtayFabry changed the title pin sphinx versions fix docs build failing Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #332 (f682cfc) into master (083e674) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          82       82           
  Lines        4722     4722           
=======================================
  Hits         4574     4574           
  Misses        148      148
Impacted Files Coverage Δ
weldx/asdf/util.py 76.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083e674...f682cfc. Read the comment docs.

@CagtayFabry
Copy link
Member Author

seems like docutils 0.17 broke some things in the notebooks :/

@CagtayFabry CagtayFabry requested review from vhirtham and marscher April 7, 2021 07:32
@CagtayFabry
Copy link
Member Author

The docs build is broken with the new docutils 0.17 so pinned to 0.16 for now to keep it running @vhirtham @marscher

We should open an issue and look into it at some point, error messages can be seen in the Actions

marscher
marscher approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. Has this already been reported upstream? So the problem is, that the titles of the notebooks are not being recognized, right?

@CagtayFabry
Copy link
Member Author

Thanks for taking care of this. Has this already been reported upstream? So the problem is, that the titles of the notebooks are not being recognized, right?

I did a quick google search but couldn't find anything so not sure
But I didn't dig into the problem either, maybe something is wrong with our notebook formatting? (I don't think so but who knows)

@CagtayFabry CagtayFabry merged commit 6884f94 into master Apr 7, 2021
@CagtayFabry CagtayFabry deleted the fix_docs_build branch April 7, 2021 08:04
marscher added a commit to marscher/weldx that referenced this pull request Apr 7, 2021
@marscher
Squashed commit of the following:
b19ad8e 
commit 54dfb05
Author: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Date:   Wed Apr 7 10:40:24 2021 +0200

    fix unit prefixes for WXRotation (BAMWelDX#327)

commit 6884f94
Author: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Date:   Wed Apr 7 10:04:50 2021 +0200

    fix docs build failing (BAMWelDX#332)

    * docutils 0.16

    * pin only docutils

    * fix type hint

commit 083e674
Author: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Date:   Tue Apr 6 19:28:18 2021 +0200

    add get_schema_path util function (BAMWelDX#325)

    * add get_schema_path util function

    * changelog und doc

commit a378d19
Author: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Date:   Tue Apr 6 14:33:44 2021 +0200

    use black 20.8b1 (BAMWelDX#331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marscher marscher marscher approved these changes

@vhirtham vhirtham Awaiting requested review from vhirtham

Assignees

@CagtayFabry CagtayFabry

Labels
bug Something isn't working CI documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagtayFabry @marscher