Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #350

Merged
merged 11 commits into from
May 3, 2021
Merged

minor fixes #350

merged 11 commits into from
May 3, 2021

Conversation

marscher
Copy link
Contributor

@marscher marscher commented Apr 30, 2021

Changes

  • enable doc tests for pytest runs (setup.cfg)
  • fix conftest import conflict for pip dist install
  • tidy up scripts directory

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #350 (4e0fcc3) into master (ce11f9d) will increase coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   96.94%   96.95%   +0.01%     
==========================================
  Files          84       85       +1     
  Lines        4875     4993     +118     
==========================================
+ Hits         4726     4841     +115     
- Misses        149      152       +3     
Impacted Files Coverage Δ
weldx/util.py 99.46% <ø> (ø)
weldx/asdf/cli/welding_schema.py 97.45% <84.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce11f9d...4e0fcc3. Read the comment docs.

@marscher
Copy link
Contributor Author

This import conflict somehow makes sense to me. There is the installed location containing conftest.py (e.g. the distribution which just got installed via pip prior invoking pytest), then the source directory (from which we invoke pytest).
It is unclear, why this just happens now. I think pip or pytest has somehow changed upstream.

The simplest workaround would be to invoke pytest for the distribution test from another directory than the source directory.

@pep8speaks
Copy link

pep8speaks commented Apr 30, 2021

Hello @marscher! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-30 16:50:43 UTC

@marscher marscher changed the title [setup.cfg] enable doctest for pytest runs minor fixes Apr 30, 2021
@marscher marscher requested a review from CagtayFabry April 30, 2021 17:03
.github/workflows/build.yml Show resolved Hide resolved
@CagtayFabry CagtayFabry mentioned this pull request Apr 30, 2021
4 tasks
@marscher marscher merged commit 19b2e97 into BAMWelDX:master May 3, 2021
@marscher marscher deleted the enable-doctests branch May 3, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants