-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weldxfile tutorial + minor fixes #355
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 96.87% 96.91% +0.03%
==========================================
Files 87 87
Lines 5214 5214
==========================================
+ Hits 5051 5053 +2
+ Misses 163 161 -2
Continue to review full report at Codecov.
|
Seems like the update to Sphinx-4.0 on RTD makes the build failing. |
reported import errors in sphinx upstream. Cref sphinx-doc/sphinx#9243 |
@CagtayFabry sorry for disturbing your writing silence. This is a blocker for ASDF-2.8 and I'd like to merge it quickly. I double checked the new tutorial and we can sort out problems with this later on. Or do you want me to open a separate PR just for the ASDF related fix(es)? |
seems like I missed the 2.8 release I will look into it #218 and this later tonight |
I used a util function of ASDF in the new WeldxFile class, which got removed. As we did not yet release that, there is no demand to rush.
But I'd like to merge both PRs soon to have a stable master branch.
I can also perform a patch release to have the new features available. Unluckily sphinx seems to be broken (reported upstream).
I will merge these on my behalf then. I also updated #218 already, so please do not ruin your precious free time ;)
|
Changes
Added a tutorial describing the basic usage of the previously introduced WeldxFile class.
Fixes
Checks