Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare nested check keys #377

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

CagtayFabry
Copy link
Member

Changes

check if keys in mappings are equal with util.compare_nested

Related Issues

Closes #376

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry requested a review from vhirtham June 21, 2021 13:30
@CagtayFabry CagtayFabry added the bug Something isn't working label Jun 21, 2021
@CagtayFabry CagtayFabry added this to the 0.4.0 milestone Jun 21, 2021
@CagtayFabry CagtayFabry added core weldx core classes and functions tests pytest (and other tests) related labels Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #377 (a297639) into master (e19fbc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          86       86           
  Lines        5366     5368    +2     
=======================================
+ Hits         5238     5240    +2     
  Misses        128      128           
Impacted Files Coverage Δ
weldx/util.py 98.97% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19fbc4...a297639. Read the comment docs.

Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix 👍

@CagtayFabry CagtayFabry merged commit f2dcc43 into BAMWelDX:master Jun 22, 2021
@CagtayFabry CagtayFabry deleted the compare_nested_check_keys branch June 22, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core weldx core classes and functions tests pytest (and other tests) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare_nested doesn't take additional dict items of RHS into account
2 participants