Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataclass_nested_eq decorator #378

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

CagtayFabry
Copy link
Member

Changes

This adds the util.dataclass_nested_eq decorator to simplify defining __eq__ on datacalsses that have array-like fileds such as np.ndarray, xarray.DataArray etc.

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added the core weldx core classes and functions label Jun 21, 2021
@CagtayFabry CagtayFabry requested a review from vhirtham June 21, 2021 14:07
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #378 (e4409b8) into master (f2dcc43) will decrease coverage by 0.05%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   97.61%   97.56%   -0.06%     
==========================================
  Files          86       86              
  Lines        5368     5376       +8     
==========================================
+ Hits         5240     5245       +5     
- Misses        128      131       +3     
Impacted Files Coverage Δ
weldx/util.py 98.23% <57.14%> (-0.74%) ⬇️
weldx/geometry.py 99.55% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2dcc43...e4409b8. Read the comment docs.

Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@CagtayFabry CagtayFabry merged commit 713a8e0 into BAMWelDX:master Jun 22, 2021
@CagtayFabry CagtayFabry deleted the dataclass_nested_eq branch June 22, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core weldx core classes and functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants