Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support string units in get_groove #416

Merged
merged 7 commits into from
Jul 13, 2021

Conversation

CagtayFabry
Copy link
Member

Changes

enable string syntax for unit in get_groove and update tutorial

Checks

  • updated CHANGELOG.md
  • update example/tutorial notebooks

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CagtayFabry CagtayFabry requested a review from vhirtham July 13, 2021 11:40
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #416 (cc254bd) into master (047d699) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          87       87           
  Lines        5352     5352           
=======================================
  Hits         5206     5206           
  Misses        146      146           
Impacted Files Coverage Δ
weldx/welding/groove/iso_9692_1.py 99.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047d699...cc254bd. Read the comment docs.

@CagtayFabry CagtayFabry added the units unit handling and pint label Jul 13, 2021
@CagtayFabry CagtayFabry self-assigned this Jul 13, 2021
@CagtayFabry CagtayFabry merged commit bed9527 into BAMWelDX:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
units unit handling and pint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants